feat(coderd/coderdtest): allow mutating deployment values #14414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Aug 23, 2024
| options.DeploymentValues.DisableOwnerWorkspaceExec = false | ||
| // This value is not safe to run in parallel. | ||
| if options.DeploymentValues.DisableOwnerWorkspaceExec { | ||
| t.Logf("WARNING: DisableOwnerWorkspaceExec is set, this is not safe in parallel tests!") |
There was a problem hiding this comment.
It'd be cool if we could actually check if parallel has been set (or will be set!), maybe we should implement out own testing.TB... 😆
There was a problem hiding this comment.
We could possibly set a dummy environment variable; this should cause t.Parallel() to panic.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows mutating deployment values.
Also modifies the check on
DisableOwnerWorkspaceExecto be a warn-log, as this caught me out for a while when testing something. Unfortunately I couldn't find a way to detect inside a test ift.Parallel()had already been called.