Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: check for .ps1 dotfiles scripts on windows #16785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 4, 2025
Merged

feat: check for .ps1 dotfiles scripts on windows #16785

merged 5 commits into from
Mar 4, 2025

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Mar 3, 2025

Closes #16702

Running bash scripts on Windows doesn't make much sense. We should prefer to look for Powershell files on Windows instead.

@aslilac aslilac requested review from Emyrk and f0ssel March 3, 2025 22:53
Emyrk
Emyrk approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this

@aslilac aslilac merged commit edf2889 into main Mar 4, 2025
30 checks passed
@aslilac aslilac deleted the lilac/platform-specific-dotfiles branch March 4, 2025 22:37
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Emyrk Emyrk Emyrk approved these changes

@f0ssel f0ssel Awaiting requested review from f0ssel

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

coder dotfiles: Run proper script based on the OS
2 participants
@aslilac @Emyrk