feat(agent): add devcontainer autostart support #17076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
added a commit
that referenced
this pull request
Mar 25, 2025
In the presence of multiple devcontainers, it would be nice to differentiate them by name. This change inherits the resource name from terraform. Refs #17076
cfea2b6 to
779c763
Compare
779c763 to
e1048b1
Compare
41fddac to
1c5a1db
Compare
1c5a1db to
2d93ee3
Compare
c78665a to
ffc2981
Compare
ffc2981 to
9c1bf01
Compare
johnstcn
approved these changes
Mar 26, 2025
| @@ -80,6 +80,21 @@ func New(opts Options) *Runner { | |||
|
|
|||
| type ScriptCompletedFunc func(context.Context, *proto.WorkspaceAgentScriptCompletedRequest) (*proto.WorkspaceAgentScriptCompletedResponse, error) | |||
|
|
|||
| type runnerScript struct { | |||
| runOnPostStart bool | |||
There was a problem hiding this comment.
suggestion: this is fine for now, but I could see this being an option on WorkspaceAgentScript in future.
There was a problem hiding this comment.
It's a good call-out 👍. I hope we figure out a better way to define dependencies or ordering for start scripts, though.
3e0c2a0 to
55c5c46
Compare
DanielleMaywood
approved these changes
Mar 27, 2025
Co-authored-by: Danielle Maywood <[email protected]>
|
/cherry-pick release/2.21 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for devcontainer autostart in workspaces. The preconditions for utilizing this feature are:
coder_devcontainerresource must be defined in Terraform@devcontainers/clitool must be installedExample Terraform:
Closes #16423
Demo of an auto-started Dev Container (logs, timings):
Demo of devcontainer defined in Terraform, but not enabled on the agent:
Demo of errors being propagated via script: