Thanks to visit codestin.com
Credit goes to github.com

Skip to content

"ane" could have been "one"#3645

Merged
DimitriPapadopoulos merged 1 commit into
codespell-project:mainfrom
yarikoptic:one
Feb 24, 2025
Merged

"ane" could have been "one"#3645
DimitriPapadopoulos merged 1 commit into
codespell-project:mainfrom
yarikoptic:one

Conversation

@yarikoptic
Copy link
Copy Markdown
Contributor

Ran into within napari/docs#587

@yarikoptic
Copy link
Copy Markdown
Contributor Author

error ane: multiple corrections must end with trailing ","

I wonder if there is some rationale for such formatting requirement?

@DimitriPapadopoulos DimitriPapadopoulos added the dictionary Changes to the dictionary label Feb 21, 2025
@DimitriPapadopoulos
Copy link
Copy Markdown
Collaborator

Note the last comma! You need to use it, otherwise the last suggestion will be discarded (see below for why).

Note that there isn't a comma at the end of the line. The last argument is treated as the reason why a suggestion cannot be automatically applied.

@yarikoptic
Copy link
Copy Markdown
Contributor Author

sorry @DimitriPapadopoulos , must be a Friday but I am still missing while trailing , is needed.

@DimitriPapadopoulos
Copy link
Copy Markdown
Collaborator

From the README:

  1. Entry with one word, but with automatic fix disabled:
    clas->class, disabled because of name clash in c++
    
    Note that there isn't a comma at the end of the line. The last argument is treated as the reason why a suggestion cannot be automatically applied.

@DimitriPapadopoulos DimitriPapadopoulos merged commit f9d3afd into codespell-project:main Feb 24, 2025
@yarikoptic
Copy link
Copy Markdown
Contributor Author

I can see that as a "feature" for a single choice, but with multiple choices - none of them can be automatically applied, so semantic of the trailing , is redundant/not needed, right?

@DimitriPapadopoulos
Copy link
Copy Markdown
Collaborator

Even with multiple choices, whatever's after the last coma is a comment. It's probably too late to change this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dictionary Changes to the dictionary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants