Convert config from XML to PHP#1914
Conversation
ed6608e to
66b6c6a
Compare
|
All green \o/ |
66b6c6a to
f520dec
Compare
|
|
||
| ->set('doctrine.orm.naming_strategy.underscore_number_aware', param('doctrine.orm.naming_strategy.underscore.class')) | ||
| ->args([ | ||
| 'CASE_LOWER', |
There was a problem hiding this comment.
@nicolas-grekas this should be an integer (the PHP constant), according to the UnderscoreNamingStrategy class
Just noticed in some deprecations :)
There was a problem hiding this comment.
arf, can you please send a PR?
| ->set('doctrine.dbal.events.oracle_session_init.class', OracleSessionInit::class) | ||
| ->set('doctrine.class', Registry::class) | ||
| ->set('doctrine.entity_managers', []) | ||
| ->set('doctrine.default_entity_manager', null) |
There was a problem hiding this comment.
I just use DBAL without the ORM and this change breaks my container:
TypeError: Doctrine\Bundle\DoctrineBundle\Registry::__construct(): Argument #5 ($defaultEntityManager) must be of type string, null given, called in /var/www/html/tests/app/var/cache/test/ContainerVbFK5Uk/getDoctrineService.php on line 27
It was <parameter key="doctrine.default_entity_manager"></parameter> in the XML config, which seems to result in an empty string instead of null.
PHP is nicer than XML and symfony/symfony#60568 might make this required at some point.