Phpunit 10#2005
Merged
Merged
Conversation
Not doing so is deprecated.
Not doing so is deprecated.
When testing without the ORM, the Events class does not exist and this causes an exception when executing the data provider.
ostrolucky
approved these changes
Sep 8, 2025
stof
reviewed
Sep 9, 2025
| unset($this->kernel, $this->commandTester); | ||
| } | ||
|
|
||
| #[WithoutErrorHandler] |
Member
There was a problem hiding this comment.
The proper way to write tests for legacy APIs is not to disable the error handler (which will also not report notices and warnings) but to add the IgnoreDeprecations attribute, which disables only the reporting of deprecations.
Member
Author
There was a problem hiding this comment.
TIL 💡
That's way more satisfying :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest major version of PHPUnit is 12 😬
I think the issue was that we relied on
symfony/phpunit-bridge. I've switched to PHPUnit's native deprecation detection system. Now it should be possible to upgrade to 11 and 12.