Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix CommandText length for stored procedures #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 30, 2022
Merged

Fix CommandText length for stored procedures #1484

merged 5 commits into from
May 30, 2022

Conversation

JRahnama
Copy link
Contributor

CommandText length cannot be more than 1046 bytes when Command type is stored procedure. This addresses The incoming tabular data stream (TDS) remote procedure call (RPC) protocol stream is incorrect. The RPC name is invalid. exception.

@Wraith2
Copy link
Contributor

Wraith2 commented Jan 21, 2022

Interesting. Makes you wonder why anyone would hit that limit.

@JRahnama
Copy link
Contributor Author

Interesting. Makes you wonder why anyone would hit that limit.

basically when it is 1046 bytes, consider each char is taking 2 bytes then the actual length of the text cannot be more than 523. Some people may get to that point. This is just to make sure that never happens.

David-Engel
David-Engel reviewed May 6, 2022
View reviewed changes
DavoudEshtehari
DavoudEshtehari reviewed May 10, 2022
View reviewed changes
@DavoudEshtehari DavoudEshtehari added this to the 5.0.0-preview3 milestone May 19, 2022
@David-Engel David-Engel requested review from DavoudEshtehari and removed request for johnnypham May 27, 2022 21:55
DavoudEshtehari
DavoudEshtehari approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't forget to modify the test scenario as we discussed.

@JRahnama JRahnama merged commit 2cfac4d into dotnet:main May 30, 2022
DavoudEshtehari pushed a commit to DavoudEshtehari/SqlClient that referenced this pull request Aug 11, 2022
@DavoudEshtehari
Fix CommandText length for stored procedures (dotnet#1484)
f184117
@DavoudEshtehari DavoudEshtehari mentioned this pull request Aug 11, 2022
Merged
Kaur-Parminder pushed a commit that referenced this pull request Aug 11, 2022
@DavoudEshtehari
Fix CommandText length for stored procedures (#1484) (#1709)
d96e36f 
Fix for CommandText length for Stored Procedures.
DavoudEshtehari pushed a commit to DavoudEshtehari/SqlClient that referenced this pull request Aug 15, 2022
@DavoudEshtehari
Fix CommandText length for stored procedures (dotnet#1484)
d30ee8e
@DavoudEshtehari DavoudEshtehari mentioned this pull request Aug 15, 2022
Merged
DavoudEshtehari added a commit to DavoudEshtehari/SqlClient that referenced this pull request Aug 16, 2022
@DavoudEshtehari
Fix CommandText length for stored procedures (dotnet#1484)
0c012d0 
# Conflicts:
#	src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj
@DavoudEshtehari DavoudEshtehari mentioned this pull request Aug 16, 2022
Merged
DavoudEshtehari added a commit that referenced this pull request Aug 23, 2022
@DavoudEshtehari
[Hotfix 2.1.5] | Fix CommandText length for stored procedures (#1484) (…
fffcb08 
…#1726)
DavoudEshtehari added a commit that referenced this pull request Sep 8, 2022
@DavoudEshtehari
[Hotfix 4.0.2] | Fix CommandText length for stored procedures (#1484) (…
4a89c1b 
…#1721)
@JRahnama JRahnama deleted the Fix-StoredPRoc-name-length branch September 29, 2022 21:25
@Kaur-Parminder Kaur-Parminder mentioned this pull request Jan 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@David-Engel David-Engel David-Engel approved these changes

@saurabh500 saurabh500 Awaiting requested review from saurabh500

+2 more reviewers

@DavoudEshtehari DavoudEshtehari DavoudEshtehari approved these changes

@Kaur-Parminder Kaur-Parminder Kaur-Parminder approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0-preview3
Development

Successfully merging this pull request may close these issues.
5 participants
@JRahnama @Wraith2 @David-Engel @DavoudEshtehari @Kaur-Parminder