Catch OSError alongside MultiPartException when closing temp files#3191
Merged
Conversation
Owner
|
You mean you got OSError on disk full? |
Contributor
Author
Yes |
Narrow the broad `except Exception` to `(MultiPartException, OSError)`. The OSError path (e.g. disk full while a SpooledTemporaryFile spills to disk) is the real leak being fixed; the test now exercises the real write path instead of patching UploadFile.write.
OSError alongside MultiPartException when closing temp files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements found during code review: added type annotations, improved error handling, fixed edge cases. All existing tests pass.