Clamp oversized suffix ranges in FileResponse#3307
Merged
Conversation
Owner
|
@cubic-dev-ai review this pull request |
@Kludex I have started the AI code review. It will take a few minutes to complete. |
FileResponse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clamp suffix byte ranges whose requested length is larger than the file size so FileResponse returns the full representation instead of treating the range as unsatisfiable.
For example,
Range: bytes=-1000against a 526-byte file should produce206withContent-Range: bytes 0-525/526.Root cause
_parse_rangescalculated suffix range starts withfile_size - suffix_length. When the suffix length exceeded the file size, that produced a negative start offset, which_parse_range_headerrejected with416.Checks
uv run pytest tests/test_responses.py::test_file_response_suffix_range_larger_than_file -quv run pytest tests/test_responses.py -k "file_response_range or file_response_suffix_range" -quv run pytest tests/test_responses.py -quv run ruff check starlette/responses.py tests/test_responses.py