fix: update uncloneable options error message (#20059)

soda-sorcery · web-flow · commit 10e7ae23e30e · 2025-09-03T10:54:31.000-04:00
* refactor: updated uncloneable-options error message to give more clarity

* updated tests to match error message change

* fix: language clean-up for clarity
diff --git a/lib/eslint/eslint.js b/lib/eslint/eslint.js
@@ -547,7 +547,7 @@ function validateOptionCloneability(options) {
 		})
 		.sort();
 	const error = new TypeError(
-		`The ${uncloneableOptionKeys.length === 1 ? "option" : "options"} ${new Intl.ListFormat("en-US").format(uncloneableOptionKeys.map(key => `"${key}"`))} cannot be cloned. When concurrency is enabled, all options must be cloneable. Remove uncloneable options or use an options module.`,
+		`The ${uncloneableOptionKeys.length === 1 ? "option" : "options"} ${new Intl.ListFormat("en-US").format(uncloneableOptionKeys.map(key => `"${key}"`))} cannot be cloned. When concurrency is enabled, all options must be cloneable values (JSON values). Remove uncloneable options or use an options module.`,
 	);
 	error.code = "ESLINT_UNCLONEABLE_OPTIONS";
 	throw error;
diff --git a/tests/lib/eslint/eslint.js b/tests/lib/eslint/eslint.js
@@ -426,7 +426,7 @@ describe("ESLint", () => {
 						constructor: TypeError,
 						code: "ESLINT_UNCLONEABLE_OPTIONS",
 						message:
-							'The options "baseConfig", "fix", and "plugins" cannot be cloned. When concurrency is enabled, all options must be cloneable. Remove uncloneable options or use an options module.',
+							'The options "baseConfig", "fix", and "plugins" cannot be cloned. When concurrency is enabled, all options must be cloneable values (JSON values). Remove uncloneable options or use an options module.',
 					},
 				);
 			});
@@ -445,7 +445,7 @@ describe("ESLint", () => {
 						constructor: TypeError,
 						code: "ESLINT_UNCLONEABLE_OPTIONS",
 						message:
-							'The option "ruleFilter" cannot be cloned. When concurrency is enabled, all options must be cloneable. Remove uncloneable options or use an options module.',
+							'The option "ruleFilter" cannot be cloned. When concurrency is enabled, all options must be cloneable values (JSON values). Remove uncloneable options or use an options module.',
 					},
 				);
 			});
@@ -9778,13 +9778,13 @@ describe("ESLint", () => {
 					const optionsSrc = `
 					import assert from "node:assert";
 					import { isMainThread } from "node:worker_threads";
-					
+
 					if (!isMainThread) {
 						if (process.env.ESLINT_TEST_ENV !== "test") {
 							assert.fail("Environment variable ESLINT_TEST_ENV is not set as expected in worker threads.");
 						}
 					}
-					
+
 					export default {
 						concurrency: 2,
 						cwd: ${JSON.stringify(fixtureDir)},
@@ -9803,11 +9803,11 @@ describe("ESLint", () => {
 				it("should propagate environment variables from worker threads to the controlling thread", async () => {
 					const optionsSrc = `
 					import { isMainThread } from "node:worker_threads";
-					
+
 					if (!isMainThread) {
 						process.env.ESLINT_TEST_ENV = "test";
 					}
-					
+
 					export default {
 						concurrency: 2,
 						cwd: ${JSON.stringify(fixtureDir)},
