Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: increase maxBuffer for ecosystem tests#20881

Merged
fasttime merged 4 commits into
eslint:mainfrom
sethamus:fix-ecosystem-test-enobufs
May 18, 2026
Merged

chore: increase maxBuffer for ecosystem tests#20881
fasttime merged 4 commits into
eslint:mainfrom
sethamus:fix-ecosystem-test-enobufs

Conversation

@sethamus

@sethamus sethamus commented May 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

When running ecosystem tests for plugins with highly verbose test suites (such as eslint-plugin-unicorn or eslint-plugin-vue), the test run fails for those plugins with an Error: spawnSync npm ENOBUFS. This occurs because spawnSync defaults to a maxBuffer limit of 1MB.

This PR increases the maxBuffer option in spawn.sync to 100MB (100 * 1024 * 1024).

#20837 (comment)

Is there anything you'd like reviewers to focus on?

@sethamus sethamus requested a review from a team as a code owner May 17, 2026 03:40
@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage May 17, 2026
@eslint-github-bot eslint-github-bot Bot added the chore This change is not user-facing label May 17, 2026
@netlify

netlify Bot commented May 17, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 898e227
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/6a0b25afc3d61e0008948e95

@fasttime fasttime moved this from Needs Triage to Triaging in Triage May 17, 2026
@fasttime

fasttime commented May 17, 2026

Copy link
Copy Markdown
Member

With these changes, the tests for eslint-plugin-unicorn and eslint-plugin-vue are passing, but the test for @typescript-eslint/typescript-eslint is now failing in CI:

https://github.com/eslint/eslint/actions/runs/25992221657/job/76400328072#step:7:95

I am able to reproduce the error on my machine where the output is more verbose:

Failed: @typescript-eslint/typescript-eslint

Errors occurred while testing plugins:

@typescript-eslint/typescript-eslint: Error: (node:90405) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 14 exit listeners added to [process]. MaxListeners is 13. Use emitter.setMaxListeners() to increase limit
(Use `node --trace-warnings ...` to show where the warning was created)
(node:90405) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 14 SIGINT listeners added to [process]. MaxListeners is 13. Use emitter.setMaxListeners() to increase limit
(node:90405) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 14 SIGTERM listeners added to [process]. MaxListeners is 13. Use emitter.setMaxListeners() to increase limit
(node:90405) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 14 SIGHUP listeners added to [process]. MaxListeners is 13. Use emitter.setMaxListeners() to increase limit

    at runCommand (file:///.../eslint/tools/test-ecosystem/index.mjs:69:26)
    at runTests (file:///.../eslint/tools/test-ecosystem/index.mjs:118:2)
    at async file:///.../eslint/tools/test-ecosystem/index.mjs:143:3

Not sure what could be the best way to fix that.

@sethamus

sethamus commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

@fasttime I’ve updated @typescript-eslint/typescript-eslint to the latest commit, which includes the fix from typescript-eslint/typescript-eslint#12339, so the tests should now pass.

@fasttime fasttime moved this from Triaging to Evaluating in Triage May 18, 2026
@fasttime

fasttime commented May 18, 2026

Copy link
Copy Markdown
Member

All tests are passing now: https://github.com/eslint/eslint/actions/runs/26061686292/job/76623184437

@fasttime fasttime added the accepted There is consensus among the team that this change meets the criteria for inclusion label May 18, 2026
@fasttime fasttime moved this from Evaluating to Implementing in Triage May 18, 2026
fasttime
fasttime approved these changes May 18, 2026
View reviewed changes

@fasttime fasttime left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit a9b8d7f into eslint:main May 18, 2026
44 checks passed
@github-project-automation github-project-automation Bot moved this from Implementing to Complete in Triage May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fasttime fasttime fasttime approved these changes
@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

Assignees

No one assigned

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing contributor pool

Projects

Triage
Status: Complete

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sethamus @fasttime @JoshuaKGoldberg