resolve Jest timeout for server-based tests#617
Merged
nfriedly merged 2 commits intoApr 19, 2026
Conversation
nfriedly
approved these changes
Apr 19, 2026
Member
|
thanks! |
Member
|
Oof, this didn't do the trick either: https://github.com/express-rate-limit/express-rate-limit/actions/runs/24637943753/job/72036615480 There's the 30/60 second thing which still doesn't seem to be working correctly, but that might be a red herring - this test should really be passing in under 30 seconds, so I think there's still some underlying flakiness that needs to be sussed out. |
nfriedly
added a commit
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved jest.setTimeout(60_000) into a beforeEach hook. this ensures the timeout is configured before the tests run
Jest's timeout enforcement now applies the extended limit from the start
Changes:
Uncommented import { platform } from 'node:process' (for platform-specific test skipping)
Wrapped the long-running server test in a describe block with proper timeout setup
Moved jest.useRealTimers() call to remain within the test function where it's needed
Fixed #611