[DOM] Attach Fragment event listeners to committed text children - #37164
Merged
Conversation
jackpope
force-pushed
the
fragment-refs/text-child-event-listeners
branch
from
July 31, 2026 19:14
6458307 to
b0f4877
Compare
jackpope
force-pushed
the
fragment-refs/text-child-event-listeners
branch
2 times, most recently
from
July 31, 2026 20:55
2a8ed2b to
44663be
Compare
jackpope
marked this pull request as ready for review
July 31, 2026 21:08
eps1lon
approved these changes
Jul 31, 2026
jackpope
force-pushed
the
fragment-refs/text-child-event-listeners
branch
from
August 9, 2026 19:15
44663be to
10ca110
Compare
eps1lon
approved these changes
Aug 10, 2026
jackpope
force-pushed
the
fragment-refs/text-child-event-listeners
branch
from
August 11, 2026 03:49
10ca110 to
e922ac3
Compare
jackpope
force-pushed
the
fragment-refs/text-child-event-listeners
branch
from
August 12, 2026 00:50
e922ac3 to
9137621
Compare
jackpope
force-pushed
the
fragment-refs/text-child-event-listeners
branch
from
August 12, 2026 01:05
9137621 to
e3d007c
Compare
poteto
approved these changes
Aug 12, 2026
poteto
left a comment
Collaborator
There was a problem hiding this comment.
LGTM (light skim). Stacking stamps for the fragment-refs land sequence.
jackpope
force-pushed
the
fragment-refs/text-child-event-listeners
branch
from
August 12, 2026 01:13
e3d007c to
6d4b7e1
Compare
Base automatically changed from
fragment-refs/cdp-document-element-empty-portal
to
main
August 12, 2026 01:19
Commit and delete previously skipped TEXT_NODE, so listeners added before a text child mounted never reached it. Match addEventListener.
jackpope
force-pushed
the
fragment-refs/text-child-event-listeners
branch
from
August 12, 2026 01:19
6d4b7e1 to
d714a33
Compare
|
Comparing: 809280d...d714a33 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit and delete previously skipped TEXT_NODE, so listeners added before a text child mounted never reached it. Match addEventListener.