[DOM] Apply Fragment listeners to children inserted into portals later - #37166
Merged
Conversation
jackpope
force-pushed
the
fragment-refs/portal-child-event-listeners
branch
from
July 31, 2026 19:14
d109b58 to
e8474b6
Compare
jackpope
force-pushed
the
fragment-refs/portal-child-event-listeners
branch
from
July 31, 2026 20:15
e8474b6 to
c91f719
Compare
jackpope
force-pushed
the
fragment-refs/portal-child-event-listeners
branch
from
July 31, 2026 20:55
c91f719 to
96726e3
Compare
jackpope
marked this pull request as ready for review
July 31, 2026 21:09
eps1lon
approved these changes
Jul 31, 2026
jackpope
force-pushed
the
fragment-refs/portal-child-event-listeners
branch
from
August 9, 2026 19:15
96726e3 to
4c2ca3b
Compare
eps1lon
approved these changes
Aug 10, 2026
jackpope
force-pushed
the
fragment-refs/portal-child-event-listeners
branch
from
August 11, 2026 03:49
4c2ca3b to
185f5cf
Compare
jackpope
force-pushed
the
fragment-refs/portal-child-event-listeners
branch
from
August 12, 2026 00:50
185f5cf to
fd3f42a
Compare
jackpope
force-pushed
the
fragment-refs/portal-child-event-listeners
branch
from
August 12, 2026 01:05
fd3f42a to
b29987a
Compare
poteto
approved these changes
Aug 12, 2026
poteto
left a comment
Collaborator
There was a problem hiding this comment.
LGTM (light skim). Stacking stamps for the fragment-refs land sequence.
jackpope
force-pushed
the
fragment-refs/portal-child-event-listeners
branch
from
August 12, 2026 01:13
b29987a to
9851ac0
Compare
jackpope
force-pushed
the
fragment-refs/portal-child-event-listeners
branch
from
August 12, 2026 01:19
9851ac0 to
89bb7fb
Compare
jackpope
force-pushed
the
fragment-refs/portal-child-event-listeners
branch
from
August 12, 2026 01:25
89bb7fb to
239f6dc
Compare
Base automatically changed from
fragment-refs/dispatch-event-document-container
to
main
August 12, 2026 01:32
Commit-time fragment ancestry stopped at HostPortal via isHostParent, so a child added after listeners were registered never received them even though existing portal siblings did. Collect fragment parents past portals and other non-HostComponent host parents so commit bookkeeping matches HostComponent/HostRoot fragment ancestry.
jackpope
force-pushed
the
fragment-refs/portal-child-event-listeners
branch
from
August 12, 2026 01:32
239f6dc to
24f3163
Compare
|
Comparing: 305feb9...24f3163 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 12, 2026
#37166) Commit-time fragment ancestry stopped at HostPortal via isHostParent, so a child added after listeners were registered never received them even though existing portal siblings did. Collect fragment parents past portals and other non-HostComponent host parents so commit bookkeeping matches HostComponent/HostRoot fragment ancestry. DiffTrain build for [fdaa617](fdaa617)
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 12, 2026
#37166) Commit-time fragment ancestry stopped at HostPortal via isHostParent, so a child added after listeners were registered never received them even though existing portal siblings did. Collect fragment parents past portals and other non-HostComponent host parents so commit bookkeeping matches HostComponent/HostRoot fragment ancestry. DiffTrain build for [fdaa617](fdaa617)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit-time fragment ancestry stopped at HostPortal via isHostParent, so a child added after listeners were registered never received them even though existing portal siblings did. Collect fragment parents past portals and other non-HostComponent host parents so commit bookkeeping matches HostComponent/HostRoot fragment ancestry.