[Fiber] Run Fragment deletion effects for HostText children - #37168
Merged
Conversation
jackpope
force-pushed
the
fragment-refs/text-child-deletion-effects
branch
from
July 31, 2026 19:15
9c03633 to
2d5a72c
Compare
jackpope
force-pushed
the
fragment-refs/text-child-deletion-effects
branch
from
July 31, 2026 20:15
2d5a72c to
c1d3ba3
Compare
jackpope
force-pushed
the
fragment-refs/text-child-deletion-effects
branch
from
July 31, 2026 20:55
c1d3ba3 to
ee3e694
Compare
jackpope
marked this pull request as ready for review
July 31, 2026 21:09
eps1lon
reviewed
Jul 31, 2026
| if (enableFragmentRefs && enableFragmentRefsTextNodes) { | ||
| commitFragmentInstanceInsertionEffects(finishedWork); | ||
| } | ||
| break; |
Collaborator
There was a problem hiding this comment.
Was it intentional that we no longer run recursivelyTraverseReappearLayoutEffects for HostText? I guess this doesn't change any behavior right now but just want to make sure we're not breaking some implicit assumptions.
Collaborator
Author
There was a problem hiding this comment.
HostText is always a leaf so it should be fine to handle this directly against the node for disappear/reappear
jackpope
force-pushed
the
fragment-refs/text-child-deletion-effects
branch
from
August 9, 2026 19:15
ee3e694 to
4240abd
Compare
jackpope
force-pushed
the
fragment-refs/text-child-deletion-effects
branch
from
August 11, 2026 03:49
4240abd to
25d3ba2
Compare
poteto
approved these changes
Aug 12, 2026
poteto
left a comment
Collaborator
There was a problem hiding this comment.
LGTM (light skim). Stacking stamps for the fragment-refs land sequence.
Base automatically changed from
fragment-refs/extract-fragment-instance
to
main
August 12, 2026 01:46
HostText entered deletion and disappear/reappear switches past the HostComponent cases that called fragment instance bookkeeping, so text children kept listeners after delete and while Activity-hidden. Handle HostText explicitly in those paths.
jackpope
force-pushed
the
fragment-refs/text-child-deletion-effects
branch
from
August 12, 2026 01:57
25d3ba2 to
1448cff
Compare
|
Comparing: 22e4f99...1448cff Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
approved these changes
Aug 12, 2026
github-actions Bot
pushed a commit
to code/lib-react
that referenced
this pull request
Aug 13, 2026
) There was inconsistent behavior with text nodes retaining event listeners while all other nodes have them removed in deletion effects. This fixes that handling DiffTrain build for [9880384](react@9880384)
github-actions Bot
pushed a commit
to code/lib-react
that referenced
this pull request
Aug 13, 2026
) There was inconsistent behavior with text nodes retaining event listeners while all other nodes have them removed in deletion effects. This fixes that handling DiffTrain build for [9880384](react@9880384)
This was referenced Aug 13, 2026
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was inconsistent behavior with text nodes retaining event listeners while all other nodes have them removed in deletion effects. This fixes that handling