Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@fredzqm
Copy link
Contributor

@fredzqm fredzqm commented Jul 17, 2025

  • [added] Support for full-text search on string fields. Add the @searchable directive to fields you want to search over, and the pluralType_search field on Query will perform full-text search.
  • [added] Support for user-defined enums in GraphQL Schemas and Operations, as well as in generated SDKs.
  • [changed] Move SQL / CEL errors to the GraphQL debug_details fields.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on upgrading the Firebase Data Connect Emulator to its latest version, 2.10.0. This upgrade introduces significant new capabilities, including full-text search functionality and support for user-defined enums in GraphQL. Additionally, it refines how certain errors are reported, moving them to a more appropriate debug field. The changes involve updating the emulator's version and download metadata, and documenting these changes in the changelog.

Highlights

  • Data Connect Emulator Update: The Firebase Data Connect Emulator has been updated to version 2.10.0, bringing new features and improvements.
  • New Feature: Full-Text Search: Support for full-text search on string fields has been added. This is enabled via the @searchable directive on fields and the new pluralType_search field on the Query type.
  • New Feature: User-Defined Enums: The emulator now supports user-defined enums within GraphQL Schemas and Operations, as well as in generated SDKs.
  • Improved Error Reporting: SQL and CEL errors are now moved to the debug_details fields within GraphQL responses, which should aid in debugging.
  • Emulator Version Configuration: The src/emulator/downloadableEmulatorInfo.json file has been updated to reflect the new Data Connect Emulator version (2.10.0) and its corresponding download metadata (expected size, checksums, and remote URLs) for macOS, Windows, and Linux platforms.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Data Connect Emulator to version 2.10.0. The changes involve updating the emulator's download information in downloadableEmulatorInfo.json and adding an entry to CHANGELOG.md. The update to the JSON configuration appears correct and consistent. I've provided one suggestion to enhance the changelog entry to ensure it fully captures all the significant changes introduced in this new version.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@joehan joehan merged commit 7a4ce9e into master Jul 17, 2025
48 of 50 checks passed
@joehan joehan deleted the fz/fdc-release branch July 17, 2025 02:59
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants