feat(node): Vendor in @fastify/otel#16328
Conversation
andreiborza
left a comment
There was a problem hiding this comment.
Looks good to me overall, what issues were you running into with the logger and TS?
The original implementation was assigning the |
e4054b0 to
cee8d3d
Compare
size-limit report 📦
|
88352b5 to
585555f
Compare
andreiborza
left a comment
There was a problem hiding this comment.
LGTM, thanks for taking care of this @onurtemizkan
585555f to
0a4e6de
Compare
| "@sentry/opentelemetry": "9.20.0", | ||
| "import-in-the-middle": "^1.13.1" | ||
| "import-in-the-middle": "^1.13.1", | ||
| "minimatch": "^9.0.0" |
There was a problem hiding this comment.
@onurtemizkan I guess adding this dependency was a mistake?
There was a problem hiding this comment.
That was intentional at the time of this PR to keep the same behaviour as the vendored origin (and to keep Node 18 support), fastify/otel#57 (comment). We can replace it, though, if we find an identically working alternative.
There was a problem hiding this comment.
Ah, thanks for the context!
Resolves: #16309
I tried to make as few modifications as possible for easier updates from the original implementation in the future.
requires andmodule.exports toimports andexportseslintconfigurationnameandversionto the vendored version instead of reading frompackage.json