Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(core): Don't gate user on logs with sendDefaultPii#16527

Merged
AbhiPrasad merged 5 commits intodevelopfrom
abhi-send-default-pii-user
Jun 16, 2025
Merged

feat(core): Don't gate user on logs with sendDefaultPii#16527
AbhiPrasad merged 5 commits intodevelopfrom
abhi-send-default-pii-user

Conversation

@AbhiPrasad
Copy link
Contributor

@AbhiPrasad AbhiPrasad requested a review from a team June 9, 2025 21:31
@AbhiPrasad AbhiPrasad self-assigned this Jun 9, 2025
@AbhiPrasad AbhiPrasad requested review from s1gr1d and stephanie-anderson and removed request for a team June 9, 2025 21:31
@mdtro
Copy link
Contributor

mdtro commented Jun 11, 2025

@AbhiPrasad Does this mean we will by default send the user's name, email, and ID? Or does it just mean that developers can use the setUser functionality without sendDefaultPII set to true?

@AbhiPrasad
Copy link
Contributor Author

If the SDK automatically collects user information (and thus calls Sentry.setUser for a user), we should gate this behind sendDefaultPii.

If a user explicitly calls Sentry.setUser, thats not default PII, that's the user opting in explicitly to the behaviour, so we should attach user information to all outgoing events as appropriate.

In this change we just remove sendDefaultPii gating user scope info (from Sentry.setUser) being applied to logs. We do not change behaviour about setting user automatically for users. Essentially we assume if the user info is already on the scope, the user wants to also see it in their events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants