feat(astro): Deprecate passing runtime config to astro integration#16839
Merged
feat(astro): Deprecate passing runtime config to astro integration#16839
Conversation
There was a problem hiding this comment.
Bug: Sentry Vite Plugin Ignores Astro's `excludeTracing`
The excludePerformanceMonitoring mapping for options.bundleSizeOptimizations?.excludeTracing was prematurely removed from the Sentry Vite plugin configuration. This mapping translated the Astro integration's excludeTracing option to the Vite plugin's excludePerformanceMonitoring option. Its removal, intended for a future Vite plugin version (v2.22.0) not yet guaranteed, causes the excludeTracing option to be ignored, breaking bundle size optimizations for users who rely on it to exclude performance monitoring.
packages/astro/src/integration/index.ts#L104-L108
sentry-javascript/packages/astro/src/integration/index.ts
Lines 104 to 108 in 9c4b98c
Was this report helpful? Give feedback by reacting with 👍 or 👎
Lms24
approved these changes
Jul 8, 2025
0xbad0c0d3
pushed a commit
to 0xbad0c0d3/sentry-javascript
that referenced
this pull request
Jul 11, 2025
…etsentry#16839) Closes getsentry#16837 This should not break anything, I actually added a test to verify injecting this works as expected. We now simply console.warn when some runtime config is passed in the astro integration. Also, no more type completion exists for these, but they are still accepted via `Record<string, unknown>`.
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16837
This should not break anything, I actually added a test to verify injecting this works as expected. We now simply console.warn when some runtime config is passed in the astro integration. Also, no more type completion exists for these, but they are still accepted via
Record<string, unknown>.