fix(node-core): Apply correct SDK metadata#17014
Merged
andreiborza merged 3 commits intodevelopfrom Jul 15, 2025
Merged
Conversation
There was a problem hiding this comment.
Bug: Node SDK Metadata Overwrite Error
The Node SDK incorrectly reports 'sentry.javascript.node-core' metadata instead of 'sentry.javascript.node'. This occurs because the applySdkMetadata call for 'node' in the Node SDK's _init function is overwritten by a subsequent applySdkMetadata call for 'node-core' within initNodeCore, as both operate on the same options object.
packages/node/src/sdk/index.ts#L52-L59
sentry-javascript/packages/node/src/sdk/index.ts
Lines 52 to 59 in 88a975a
packages/node-core/src/sdk/index.ts#L123-L124
sentry-javascript/packages/node-core/src/sdk/index.ts
Lines 123 to 124 in 88a975a
Was this report helpful? Give feedback by reacting with 👍 or 👎
Contributor
size-limit report 📦
|
chargome
approved these changes
Jul 15, 2025
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While adding the SDK to the release-registry I noticed that we never apply the correct metadata to node-core.
64d056a failing tests show the node-core SDK getting incorrect
sentry.javascript.nodemetadata (fromNodeClient)88a975a applies correct metadata to both SDKs
I was debating changing the underlying
NodeClientto not automatically setsentry.javascript.nodebut wasn't sure of the implications so decided not to.