feat(node-core): Expand @opentelemetry/instrumentation range to cover 0.203.0#17043
feat(node-core): Expand @opentelemetry/instrumentation range to cover 0.203.0#17043andreiborza merged 4 commits intodevelopfrom
@opentelemetry/instrumentation range to cover 0.203.0#17043Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Lms24
left a comment
There was a problem hiding this comment.
^0.202.0 doesn't allow 0.203.0?
|
Actually it does... will close this 😅. edit: actually it doesn't. So this is a mess, |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
016ab81 to
ee888c2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
packages/node-core/package.json
Outdated
| "@opentelemetry/context-async-hooks": "^1.30.1 || ^2.0.0", | ||
| "@opentelemetry/core": "^1.30.1 || ^2.0.0", | ||
| "@opentelemetry/instrumentation": "^0.57.1 || ^0.202.0", | ||
| "@opentelemetry/instrumentation": "^0.57.1 || >=0.200.0 <1", |
There was a problem hiding this comment.
actually, can this just be >= 0.57.1 <1? 😅
There was a problem hiding this comment.
Bug: OpenTelemetry Dependency Removal Error
The @opentelemetry/instrumentation dependency was accidentally removed from both peerDependencies and devDependencies in packages/opentelemetry/package.json. This is inconsistent with the PR's goal of expanding OpenTelemetry version support (e.g., to include 0.203.0 or ">=0.57.1 <1" as seen in other packages), and will break OpenTelemetry integration.
packages/opentelemetry/package.json#L46-L54
sentry-javascript/packages/opentelemetry/package.json
Lines 46 to 54 in e6df021
Was this report helpful? Give feedback by reacting with 👍 or 👎
No description provided.