fix(v9/remix): Ensure source maps upload fails silently if Sentry CLI fails#17095
Merged
fix(v9/remix): Ensure source maps upload fails silently if Sentry CLI fails#17095
Conversation
…ils (#17082) Sentry CLI's `cli.releases.uploadSourceMaps` method previously never rejected when the actual CLI binary execution exited with an error code. In CLI 2.49.0 (and 2.50.0) I added a new live mode `rejectOnError` which continues to pipe stdio to the process (the remix SDKs' upload script) but now also rejects on error. This PR 1. bumps Sentry CLI, 2. configures the CLI to actually reject now but 3. also catches the rejection and logs a message. I decided to still continue with the script because we should still delete source maps. Otherwise, we risk deploying them when users expect them to be deleted. (i.e. fail silently but correctly :D)
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
andreiborza
approved these changes
Jul 21, 2025
Co-authored-by: Andrei <[email protected]>
There was a problem hiding this comment.
Bug: Sentry Source Maps Upload Failures and Data Loss
The createRelease.js script now silently fails to upload source maps and prematurely deletes local files.
- An invalid
live: 'rejectOnError'option passed tosentry.releases.uploadSourceMapscauses the Sentry CLI to error, preventing uploads. This error is silently swallowed by a newtry...catchblock. - Due to errors from
uploadSourceMapsandfinalizebeing swallowed,deleteSourcemapsnow executes unconditionally when--deleteAfterUploadis used. This deletes local source maps even if they were never successfully uploaded or finalized, leading to data loss and preventing debugging or re-uploads.
packages/remix/scripts/createRelease.js#L29-L54
sentry-javascript/packages/remix/scripts/createRelease.js
Lines 29 to 54 in 003c253
Was this report helpful? Give feedback by reacting with 👍 or 👎
Lms24
added a commit
that referenced
this pull request
Jul 21, 2025
Small cleanup forward-port to `develop` (see #17095 (comment).) Co-authored-by: Andrei <[email protected]>
This was referenced Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #17082