Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: query() now warns when job_id is set and the default job_retry is ignored #2167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 24, 2025
Merged

fix: query() now warns when job_id is set and the default job_retry is ignored #2167

merged 5 commits into from
Apr 24, 2025

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Apr 21, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@tswast tswast requested review from a team as code owners April 21, 2025 17:08
@tswast tswast requested a review from suzmue April 21, 2025 17:08
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Apr 21, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Apr 21, 2025
@tswast tswast requested a review from chalmerlowe April 21, 2025 17:08
tswast
tswast commented Apr 21, 2025
View reviewed changes
shollyman
shollyman approved these changes Apr 23, 2025
View reviewed changes
@tswast tswast enabled auto-merge (squash) April 24, 2025 18:58
@shollyman shollyman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2025
@shollyman
Copy link
Contributor

rerunning kokoro, infra issues should be resolved.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2025
@tswast tswast merged commit ca1798a into main Apr 24, 2025
14 of 18 checks passed
@tswast tswast deleted the tswast-job_id-warning branch April 24, 2025 20:47
@release-please release-please bot mentioned this pull request Apr 24, 2025
Merged
This was referenced May 20, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@suzmue suzmue Awaiting requested review from suzmue suzmue is a code owner automatically assigned from googleapis/api-bigquery

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe

Assignees

@shollyman shollyman

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @shollyman @yoshi-kokoro