Fix reload mode by implementing close on the client#8548
Merged
Conversation
Collaborator
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/97126cb594229b15ec033064613512a42f474dd3/gradio-4.36.1-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@97126cb594229b15ec033064613512a42f474dd3#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-builds.s3.amazonaws.com/97126cb594229b15ec033064613512a42f474dd3/gradio-client-1.1.1.tgz |
Collaborator
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
pngwn
reviewed
Jun 13, 2024
Member
There was a problem hiding this comment.
Don't we have an existing reload test?
Contributor
Author
There was a problem hiding this comment.
This specific issue is triggered when there are state components so used a different demo/file for that case
pngwn
approved these changes
Jun 13, 2024
pngwn
left a comment
Member
There was a problem hiding this comment.
Looks great. Thanks @freddyaboulton!
Contributor
Author
|
Thank you @pngwn 🙏 |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reload mode would break because the heartbeat could not be closed -
You can test by with a stateful demo like ChatInterface
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh