Cloudwatch: Deprecate cloudwatchNewRegionsHandler feature toggle and remove core imports from featuremgmt #81310
Conversation
|
|
There was a problem hiding this comment.
A couple clean up comments, but nice work!
I tried shutting off the cross account querying flag, and it did successfully use the old log group picker.
I would double check (maybe in slack?) that we're ok to remove that flag before we remove it and that none of the users are having issues.
There was a problem hiding this comment.
Leftover comment? (And below)
pkg/tsdb/cloudwatch/test_utils.go
Outdated
There was a problem hiding this comment.
Just as a nit, it doesn't need to be exported
| func ContextWithFeaturesEnabled(enabled ...string) context.Context { | |
| func contextWithFeaturesEnabled(enabled ...string) context.Context { |
There was a problem hiding this comment.
Indeed! I thought it did at some point - maybe I was using it in a subpackage? - but it sure doesn't now
There was a problem hiding this comment.
If we're removing the toggle I don't think we need to reference it
| it('should always return regions as an array of options now that the feature toggle has been removed', async () => { | |
| it('should always return regions as an array of options', async () => { |
There was a problem hiding this comment.
this is really neat, does this mean we could have backend feature toggles in our external datasource plugins if we implemented something similar there? 👀 very nifty!
|
oh also random, but I tend to mark nearly everything in Add To Changelog. In this case in particular where we are deprecating a feature toggle I think it would be good. We haven't seen bugs come in to my knowledge, but you never know who might have turned off the feature toggle on their own on prem instance or something like that without reporting a bug. This way if something unexpected happens with Cloudwatch after an upgrade a user can quickly scan the changelog and see some possible threads to pull on to try to figure out what happened. To that end I might change the name of this pr from |
|
Re: removing the flag, it's the new regions handler that's being removed (just to make sure we're on the same page) and I got the 👍🏻 from @sarahzinger in slack for that. |
f92e2ab to
ecd3372
Compare
ecd3372 to
af58d84
Compare
…remove core imports from featuremgmt via grafana/grafana#81310 * Remove core imports from grafana/pkg/services/featuremgmt in CloudWatch
What is this feature?
This removes some core grafana imports from Cloudwatch. Also removes the
cloudwatchNewRegionsHandlerfeature, which is obsolete.Why do we need this feature?
This is part of decoupling cloudwatch from core grafana, #78778.
Which issue(s) does this PR fix?:
Fixes: #80899
Please check that: