Cookies: Provide a mechanism for per user control over cookies #61566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…something # Conflicts: # packages/grafana-data/src/types/featureToggles.gen.ts # pkg/services/featuremgmt/registry.go # pkg/services/featuremgmt/toggles_gen.go # pkg/setting/setting.go
chri2547
reviewed
Jan 24, 2023
docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md
Outdated
Show resolved
Hide resolved
Collaborator
|
Looks good to me, nice branch name ;) |
…something # Conflicts: # docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md # packages/grafana-data/src/types/featureToggles.gen.ts # pkg/api/login.go # pkg/api/preferences.go # pkg/services/featuremgmt/registry.go # pkg/services/featuremgmt/toggles_gen.go # pkg/services/preference/model.go # pkg/services/preference/prefimpl/pref.go
mildwonkey
approved these changes
Feb 8, 2023
Contributor
mildwonkey
left a comment
There was a problem hiding this comment.
👍 I think this is a sufficient solution for the time being, which we can revisit as more weird cookie preferences arise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This focuses primarily on enabling access to Google Analytics for users that are in areas where analytics is regulated and require user consent. This doesn't add that consent system, but it allows users that have an external consent tracking system to record consents on the user's profile preferences within Grafana.
Why do we need this feature?
It comes up from time to time that using Grafana with Google Analytics enabled in a regulated area might be problematic. This aims to provide parts of the framework we need to solve that.
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer: