Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Dashboard: Add value format for requests per minute #62258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2023
Merged

Dashboard: Add value format for requests per minute #62258

merged 1 commit into from
Mar 27, 2023

Conversation

@dwradcliffe
Copy link
Contributor

@dwradcliffe dwradcliffe commented Jan 26, 2023

What is this feature?

Add value format for throughput: requests per minute (rpm).

Why do we need this feature?

We have a lot of graphs that use rpm instead of rps. This allows us to use the right formatting.

Who is this feature for?

Anyone building dashboards.

Which issue(s) does this PR fix?:

N/A

@dwradcliffe dwradcliffe requested review from a team as code owners January 26, 2023 18:27
@dwradcliffe dwradcliffe requested a review from a team January 26, 2023 18:27
@dwradcliffe dwradcliffe requested a review from a team as a code owner January 26, 2023 18:27
@dwradcliffe dwradcliffe requested review from codeincarnate, joshhunt, leventebalogh, oscarkilhed and yaelleC and removed request for a team January 26, 2023 18:27
@CLAassistant
Copy link

CLAassistant commented Jan 26, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dwradcliffe dwradcliffe requested review from axelavargas and polibb and removed request for a team January 26, 2023 18:27
@grafanabot grafanabot added area/frontend pr/external This PR is from external contributor labels Jan 26, 2023
@polibb polibb added this to the 9.4.1 milestone Feb 17, 2023
polibb
polibb approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@polibb polibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as expected :). LGTM

@polibb polibb added the no-backport Skip backport of PR label Feb 17, 2023
@mckn mckn requested review from mckn and removed request for leventebalogh February 21, 2023 07:34
mckn
mckn approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@polibb
Copy link
Contributor

polibb commented Feb 23, 2023

Hi @dwradcliffe 🙌. We are ready to merge this PR, but there's some checks failing - main concern is the one detecting breaking changes.
I went through them and they have nothing to do with your work, but it would be necessary to sync your branch with the latest changes in main we have, so that the checks run again and we handle any problems if there are any real ones before merging.

@zerok zerok modified the milestones: 9.4.1, 9.4.2, 9.4.3 Feb 27, 2023
@grafanabot grafanabot removed this from the 9.4.3 milestone Mar 2, 2023
@grafanabot
Copy link
Contributor

grafanabot commented Mar 2, 2023

This pull request was removed from the 9.4.3 milestone because 9.4.3 is currently being released.

@polibb
Copy link
Contributor

polibb commented Mar 6, 2023

@dwradcliffe pinging you to request a response 👋.

@polibb polibb added stale Issue with no recent activity and removed stale Issue with no recent activity labels Mar 9, 2023
@dwradcliffe dwradcliffe force-pushed the requests_per_minute branch from c6fdfed to e929dbf Compare March 11, 2023 14:49
@dwradcliffe dwradcliffe requested a review from a team as a code owner March 11, 2023 14:49
@dwradcliffe
Copy link
Contributor Author

dwradcliffe commented Mar 11, 2023

Sorry for the delay; rebased on main.

@polibb polibb added this to the 9.4.5 milestone Mar 13, 2023
@grafanabot grafanabot removed this from the 9.4.5 milestone Mar 13, 2023
@grafanabot
Copy link
Contributor

grafanabot commented Mar 13, 2023

This pull request was removed from the 9.4.5 milestone because 9.4.5 is currently being released.

@dwradcliffe dwradcliffe force-pushed the requests_per_minute branch from e929dbf to 0595e99 Compare March 13, 2023 18:01
@polibb polibb added this to the 9.5.0 milestone Mar 22, 2023
@polibb polibb merged commit cb68b1e into grafana:main Mar 27, 2023
@dwradcliffe dwradcliffe deleted the requests_per_minute branch May 3, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mckn mckn mckn approved these changes

@joshhunt joshhunt Awaiting requested review from joshhunt joshhunt was automatically assigned from grafana/grafana-frontend-platform

@yaelleC yaelleC Awaiting requested review from yaelleC yaelleC was automatically assigned from grafana/grafana-frontend-platform

@codeincarnate codeincarnate Awaiting requested review from codeincarnate

@oscarkilhed oscarkilhed Awaiting requested review from oscarkilhed

@axelavargas axelavargas Awaiting requested review from axelavargas axelavargas is a code owner automatically assigned from grafana/dashboards-squad

+1 more reviewer

@polibb polibb polibb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

add to changelog area/frontend no-backport Skip backport of PR pr/external This PR is from external contributor

Projects

Dashboards Triage
Archived in project

Milestone

9.5.0

Development

Successfully merging this pull request may close these issues.

6 participants

@dwradcliffe @CLAassistant @polibb @grafanabot @mckn @zerok