MSSQL/Postgres: List views in table dropdown as well #62867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantxu
pushed a commit
that referenced
this pull request
Feb 8, 2023
* MSSQL: Query views for table dropdown * Postgres: Query views for table dropdown
ryantxu
pushed a commit
that referenced
this pull request
Mar 2, 2023
* MSSQL: Query views for table dropdown * Postgres: Query views for table dropdown
|
Is this issue fixed? Grafana 9.4.3 is not showing database Views, just tables in the core installed MS SQL Server plugin. Edit: This seems to be fixed since Milestone 9.5.0. I upgraded my Grafana installation to current 9.5.2 and Views now pop up like tables are, as expected. Thanks! |
Contributor
|
@Helix751 Good to hear! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that the table dropdown for the MSSQL and Postgres datasource only showed tables and not views. This pr fixes it by removing the constraint in the table query.
Which issue(s) does this PR fix?:
Fixes #59775 #62674
Special notes for your reviewer: