Logs: Rename dedup to deduplicate #62944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Backend code coverage report for PR #62944 |
Contributor
|
Frontend code coverage report for PR #62944
|
ivanahuckova
reviewed
Feb 6, 2023
Contributor
ivanahuckova
left a comment
There was a problem hiding this comment.
👍 . Could you also update the name in logs-integration.md documentation?
ivanahuckova
reviewed
Feb 6, 2023
svennergr
approved these changes
Feb 7, 2023
jdbaldry
pushed a commit
that referenced
this pull request
Feb 24, 2023
* fix: rename dedup with deduplication * docs: update documentation * fix: update names (cherry picked from commit 8a94688) Signed-off-by: Jack Baldry <[email protected]>
jdbaldry
added a commit
that referenced
this pull request
Feb 25, 2023
* [v9.4.x] Logs: Rename dedup to deduplication (#62944) * fix: rename dedup with deduplication * docs: update documentation * fix: update names (cherry picked from commit 8a94688) Signed-off-by: Jack Baldry <[email protected]> * [v9.4.x] fix link to explore with logs and headings (#63665) fixed links and eadings (cherry picked from commit a0a2181) Signed-off-by: Jack Baldry <[email protected]> --------- Co-authored-by: Gareth Dawson <[email protected]> Co-authored-by: Isabel <[email protected]>
ryantxu
pushed a commit
that referenced
this pull request
Mar 2, 2023
* fix: rename dedup with deduplication * docs: update documentation * fix: update names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
we think
dedupis a technical concept, not an actual word, and doesn't clearly communicate its meaning. this pr updates this word todeduplicate or deduplicationWhy do we need this feature?
...
Who is this feature for?
...
Which issue(s) does this PR fix?:
Fixes #62873
Special notes for your reviewer: