Feat: Changing link destination for get more plugins #63517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolzhabayev
commented
Feb 21, 2023
| /public/app/features/correlations/ @grafana/explore-squad | ||
| /public/app/features/dashboard/ @grafana/dashboards-squad | ||
| /public/app/features/datasources/ @grafana/user-essentials | ||
| /public/app/features/datasources/ @grafana/plugins-platform-frontend |
Contributor
Author
There was a problem hiding this comment.
switching ownership to plugins platform
Contributor
Author
|
fyi @mjseaman |
leventebalogh
approved these changes
Mar 1, 2023
Contributor
leventebalogh
left a comment
There was a problem hiding this comment.
LGTM, left one comment. 👍
public/app/features/datasources/components/DataSourceCategories.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Changing the link destination for "find more plugins" from external to
internal plugin catalogorconnectionsdepending on if the feature flag is active or not.If feature flag
dataConnectionsConsoleis active it links to/connections/connect-data?cat=data-sourceif not it links to/plugins?filterBy=all&filterByType=datasourceWhy do we need this feature?
Keep users in grafana catalog, less confusion when searching for new plugins