Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Alerting: Use displayNameFromDS if available in preview #65342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2023
Merged

Alerting: Use displayNameFromDS if available in preview #65342

merged 1 commit into from
Mar 28, 2023

Conversation

@gillesdemey
Copy link
Contributor

@gillesdemey gillesdemey commented Mar 27, 2023

What is this feature?

Adds support for displayNameFromDS in the Alerting preview

Why do we need this feature?

Some data sources (such as Graphite) assign a name to a frame field, if this is assigned from the data source we should show that one over a generic series x.

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.
  • There are no known compatibility issues with older supported versions of Grafana, or plugins.
  • It passes the Hosted Grafana feature readiness review for observability, scalability, performance, and security.

@gillesdemey gillesdemey added type/bug area/alerting Grafana Alerting area/frontend add to changelog backport v9.4.x Mark PR for automatic backport to v9.4.x labels Mar 27, 2023
@gillesdemey gillesdemey added this to the 9.4.x milestone Mar 27, 2023
@gillesdemey gillesdemey requested a review from a team March 27, 2023 11:58
@gillesdemey gillesdemey self-assigned this Mar 27, 2023
@github-advanced-security

This comment was marked as off-topic.

Sign in to view
soniaAguilarPeiron
soniaAguilarPeiron approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@soniaAguilarPeiron soniaAguilarPeiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gillesdemey gillesdemey merged commit f68fd83 into main Mar 28, 2023
@gillesdemey gillesdemey deleted the alerting/fix-preview-series-dsname branch March 28, 2023 11:58
@grafanabot

This comment was marked as resolved.

Sign in to view
@grafanabot grafanabot added the backport-failed Failed to generate backport PR. Please resolve conflicts and create one manually. label Mar 28, 2023
gillesdemey added a commit that referenced this pull request Mar 28, 2023
@gillesdemey
Alerting: Use displayNameFromDS if available in preview (#65342)
eca296a 
(cherry picked from commit f68fd83)
@gillesdemey gillesdemey mentioned this pull request Mar 28, 2023
Merged
gillesdemey added a commit that referenced this pull request Mar 28, 2023
@gillesdemey
Alerting: Use displayNameFromDS if available in preview (#65342) (#65445
ef6476d 
)
@itsmylife itsmylife mentioned this pull request Apr 11, 2023
Merged
@zerok zerok modified the milestones: 9.4.x, 9.4.8, 9.5.0 Apr 12, 2023
@zerok zerok mentioned this pull request Jun 27, 2023
Closed
@gotjosh gotjosh mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soniaAguilarPeiron soniaAguilarPeiron soniaAguilarPeiron approved these changes

Assignees

@gillesdemey gillesdemey

Labels

add to changelog area/alerting Grafana Alerting area/frontend backport v9.4.x Mark PR for automatic backport to v9.4.x backport-failed Failed to generate backport PR. Please resolve conflicts and create one manually. type/bug

Projects

Alerting
Archived in project

Milestone

9.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@gillesdemey @grafanabot @soniaAguilarPeiron @zerok