Dashboard: When dashboard is not found show message instead of empty page #65508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
You have successfully added a new CodeQL configuration |
dprokop
approved these changes
Mar 30, 2023
Contributor
dprokop
left a comment
There was a problem hiding this comment.
Can we reuse the view from https://github.com/grafana/grafana/blob/dashboard/not-found-page/public/app/core/components/ErrorPage/ErrorPage.tsx#L8 for consistency?
Other than that this looks good.
Contributor
Author
Yes, and I like the fact that it looks less like a dashboard you can do stuff on 😁. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Adds a view for Not Found dashboard.
Why do we need this feature?
Because Not Found dashboard is treated the same as an empty one right now.
Special notes for your reviewer:
I think we can also stop the initialisation of the dashboard here: initDashboard#L161 by sending a
dispatch(dashboardInitFailed({ message: 'Not found', error: 'Not found' }))and render the Failed page. Thoughts?Please check that: