Annotation List: Fix panel not updating when variable is changed #65899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 421bd0bb7e6220f1c0a65b60696e258003ebf91d Author: Joao Silva <[email protected]> Date: Tue Apr 4 10:48:04 2023 +0100 user essentials mob! :trident: lastFile:public/app/plugins/panel/annolist/AnnoListPanel.tsx commit 862846a39d774ba78861d567b6fd42fe7e4793ad Author: joshhunt <[email protected]> Date: Tue Apr 4 10:35:35 2023 +0100 user essentials mob! :trident: commit 4ddc7febbb790ba4ff65e2739246c951a4ddbe34 Author: Tobias Skarhed <[email protected]> Date: Tue Apr 4 11:20:08 2023 +0200 mob next [ci-skip] [ci skip] [skip ci] lastFile:public/app/plugins/panel/annolist/AnnoListPanel.tsx Co-authored-by: joshhunt <[email protected]> Co-authored-by: Tobias Skarhed <[email protected]>
joshhunt
approved these changes
Apr 4, 2023
grafanabot
pushed a commit
that referenced
this pull request
Apr 17, 2023
Squashed commit of the following: commit 421bd0bb7e6220f1c0a65b60696e258003ebf91d Author: Joao Silva <[email protected]> Date: Tue Apr 4 10:48:04 2023 +0100 user essentials mob! :trident: lastFile:public/app/plugins/panel/annolist/AnnoListPanel.tsx commit 862846a39d774ba78861d567b6fd42fe7e4793ad Author: joshhunt <[email protected]> Date: Tue Apr 4 10:35:35 2023 +0100 user essentials mob! :trident: commit 4ddc7febbb790ba4ff65e2739246c951a4ddbe34 Author: Tobias Skarhed <[email protected]> Date: Tue Apr 4 11:20:08 2023 +0200 mob next [ci-skip] [ci skip] [skip ci] lastFile:public/app/plugins/panel/annolist/AnnoListPanel.tsx Co-authored-by: joshhunt <[email protected]> Co-authored-by: Tobias Skarhed <[email protected]> (cherry picked from commit 8ffd58a)
adela-almasan
pushed a commit
that referenced
this pull request
Apr 17, 2023
Squashed commit of the following: commit 421bd0bb7e6220f1c0a65b60696e258003ebf91d Author: Joao Silva <[email protected]> Date: Tue Apr 4 10:48:04 2023 +0100 user essentials mob! :trident: lastFile:public/app/plugins/panel/annolist/AnnoListPanel.tsx commit 862846a39d774ba78861d567b6fd42fe7e4793ad Author: joshhunt <[email protected]> Date: Tue Apr 4 10:35:35 2023 +0100 user essentials mob! :trident: commit 4ddc7febbb790ba4ff65e2739246c951a4ddbe34 Author: Tobias Skarhed <[email protected]> Date: Tue Apr 4 11:20:08 2023 +0200 mob next [ci-skip] [ci skip] [skip ci] lastFile:public/app/plugins/panel/annolist/AnnoListPanel.tsx Co-authored-by: joshhunt <[email protected]> Co-authored-by: Tobias Skarhed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Currently if you have an annotation list panel that uses a variable to query for tags, updating the variable does not refresh the panel, this fixes that. (see issue #65349 for more detail)
Why do we need this feature?
To allow users to use variables to search for annotations with certain tags
Who is this feature for?
Users of annotation list panel
Which issue(s) does this PR fix?:
Fixes #65349
Special notes for your reviewer:
This solution does not seem ideal, to update on every
renderCounterchange (the same as the Dashboard List panel does), we did try to look to subscribe to some type of "variable changed" event, but could not get to work properly. @grafana/dashboards-squad if you have any hints for that let us know.Please check that: