TransformationFilter: Implement RefID multi picker #96841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeoniya
approved these changes
Nov 21, 2024
LGTM!
leeoniya
reviewed
Nov 21, 2024
packages/grafana-ui/src/components/MatchersUI/FieldsByFrameRefIdMatcher.tsx
Outdated
Show resolved
Hide resolved
This was referenced Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to duplicate existing RefIDPicker and adjust for multi select as it is being used in several other places (like geomap plugin, MatchersUI) and I am not entirely sure that we want to change this across the board. Let me know if thats the way to go or we would want to have multi picker across the board
Fixes: #96574