Update shadow plugin after ownership change #3791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 306 files 306 suites 45s ⏱️ Results for commit 5704b59. |
bbakerman
approved these changes
Jan 22, 2025
| id 'signing' | ||
| id "com.github.johnrengelman.shadow" version "8.1.1" | ||
| id "com.gradleup.shadow" version "8.3.0" | ||
| id "biz.aQute.bnd.builder" version "6.4.0" |
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original maintainer of shadow has handed over the project to GradleUp, an umbrella organisation that manages Gradle open source projects.
Good news is, the project is continuing. The only difference is the plugin ID changes to reflect the new ownership by GradleUp.
This PR pulls in the next closest version to what we had before, to minimise breaking changes.
As a paranoid end-to-end check, I created the jar with shading with this new plugin version, and pulled it into a separate project, running our Hello World example which requires Antlr to work. It still works.
GitHub thread explaining ownership change: GradleUp/shadow#908
Changelog with 8.3.0 release notes: https://github.com/GradleUp/shadow/blob/main/src/docs/changes/README.md#v830-2024-08-08