Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dondonz
Copy link
Member

@dondonz dondonz commented Mar 28, 2025

Fixes 2 problems seen lately on our performance pipeline, after enabling multiple concurrent runs

  1. Too many jobs. We sent 36 jobs off in the space of a few minutes which was unnecessary. This is because the performance pipeline is triggered on every master commit, and some branches had many commits. This wasn't a problem before enabling concurrent pipeline runs. Solution: change the performance pipeline to trigger on pull request merge instead
  2. We had a race condition, because two performance pipeline runs completed at almost the same time. The second pipeline couldn't commit the results because the HEAD of master changed during the copy step of the 2nd pipeline. Solution: add another git pull before committing results. Example of race condition: https://github.com/graphql-java/graphql-java/actions/runs/14025083675/job/39262341170

@dondonz dondonz added the not release related changes which are not released (for example unit tests or docs) label Mar 28, 2025
@dondonz dondonz added this to the 23.0 breaking changes milestone Mar 28, 2025
@github-actions
Copy link
Contributor

Test Results

  311 files    311 suites   46s ⏱️
3 576 tests 3 570 ✅ 6 💤 0 ❌
3 665 runs  3 659 ✅ 6 💤 0 ❌

Results for commit 57487ae.

push:
pull_request:
types:
- closed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closed, but not merged? Or does close mean merged here?

Copy link
Member Author

@dondonz dondonz Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no specific "merged" event. See the documentation, I thought "closed" would be the closest to what we want https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request

@dondonz dondonz merged commit 8b665ef into master Apr 3, 2025
2 checks passed
@dondonz dondonz deleted the performance-pipeline-improvements branch April 3, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not release related changes which are not released (for example unit tests or docs)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants