I get the problem and agree that this needs to be improved, but I am not sure just returning null is the right solution. @bbakerman @dondonz thoughts?

So location is an optional field with an array of locations

If an error can be associated to a particular point in the requested GraphQL document, it should contain an entry with the key locations with a list of locations, where each location is a map with the keys line and column, both positive numbers starting from 1 which describe the beginning of an associated syntax element.

So this makes sense to me - if we ended up with a array of locations where one of them is null - then just making it null makes sense

We have had this code since November 2024

    public static Object locations(List<SourceLocation> locations) {
        return mapAndDropNulls(locations, GraphqlErrorHelper::location);
    }

It was fixed by donna in 69569de

@bbakerman ok ... approved

Thanks for this PR - I cant believe we went this long without any reporting this

Thanks for the PR!

Thanks for merging so fast!

Thanks for this PR - I cant believe we went this long without any reporting this

I'm guessing it never got caught because it popped up when generating a schema, not when executing a query.

In the general case, an application wouldn't serialise an error caused during schema generation. We just have a somewhat niche use case.