vet: adds a check to disallow usage of regex.Compile in xDS code - #9216
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9216 +/- ##
==========================================
- Coverage 83.19% 83.16% -0.04%
==========================================
Files 420 420
Lines 34010 34024 +14
==========================================
Hits 28295 28295
- Misses 4281 4288 +7
- Partials 1434 1441 +7 🚀 New features to boost your workflow:
|
Member
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a static analysis check in scripts/vet.sh to prevent direct calls to regexp.Compile in xDS production code. The reviewer suggested extending this check to also disallow regexp.MustCompile to ensure complete safety, providing a code suggestion to implement this using git grep's -e and --or flags.
arjan-bal
approved these changes
Jul 3, 2026
Comment on lines
+93
to
+94
|
|
||
|
|
Contributor
There was a problem hiding this comment.
nit: A single blank line is sufficient for vertical separation.
Member
Author
There was a problem hiding this comment.
Added by mistake. Cleaned it up. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes : #9153
This PR adds a check to disallow usage of regex.Compile in xDS code.
Excludes the following from check :
SafeRegexfunction liveshashPoliciesProtoToSliceneeds to use it becuase it requires partial matches too , to replace the substring.RELEASE NOTES: None