Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

sethvargo
Copy link
Contributor

This updates goreleaser to also publish ARM and AMD binaries for target platforms.

There were two build targets that were identical, so I merged them.

This updates goreleaser to also publish ARM and AMD binaries for target platforms.

There were two build targets that were identical, so I merged them.
@sethvargo sethvargo requested a review from a team as a code owner April 15, 2025 16:03
@crw
Copy link
Contributor

crw commented Apr 15, 2025

Please ignore my previous (now deleted) comment, I did not notice the project was go-getter. Thanks for this submission.

@sethvargo
Copy link
Contributor Author

Thanks @crw - I did not see your previous comment. Please let me know what is required to unblock this.

@crw
Copy link
Contributor

crw commented Apr 16, 2025

I believe at this point it is up to the @hashicorp/team-ip-compliance to review and merge these types of pull requests. If there is significance to the Terraform Core team (e.g., solves an issue or unblocks a PR), let me know and I can prioritize it with product.

@sethvargo
Copy link
Contributor Author

No, but I'd like to get a human on it :). I cannot see/tag @hashicorp/team-ip-compliance (it appears to be an internal/hidden team), so I'm not sure they are getting notifications given this is a public repo. It's also not assigned to them:
CleanShot 2025-04-16 at 13 13 32@2x

@crw
Copy link
Contributor

crw commented Apr 16, 2025

I did not know that, but they were automatically requested as reviewers when the PR was filed.

Copy link
Contributor

@mukeshjc mukeshjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Seth for the PR.
My team (IP compliance) has recently taken ownership of such shared OSS repos that are used across multiple Hashi products. We are reforming our processes to have a better control of changes that occur across tens of such repositories that we now own. Thank you for your patience on this one.

@mukeshjc mukeshjc merged commit 5f1a809 into hashicorp:main May 30, 2025
1 check passed
@sethvargo sethvargo deleted the patch-1 branch May 30, 2025 12:55
@sethvargo
Copy link
Contributor Author

Thank you!

@sethvargo
Copy link
Contributor Author

Any chance you could publish a new release? :)

@dduzgun-security
Copy link
Collaborator

dduzgun-security commented Aug 15, 2025

@sethvargo a new release is now available v1.7.9, thanks again for the contribution. 🙏

@sethvargo
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants