Remove remaining execSync calls

haydenbleasel · haydenbleasel · commit 71aeca4e33ec · 2026-04-14T21:43:04.000-07:00
diff --git a/.changeset/tidy-actors-worry.md b/.changeset/tidy-actors-worry.md
@@ -0,0 +1,5 @@
+---
+"ultracite": patch
+---
+
+Remove remaining execSync calls
diff --git a/packages/cli/__tests__/initialize.test.ts b/packages/cli/__tests__/initialize.test.ts
@@ -866,10 +866,10 @@ describe("initialize", () => {
 
     expect(mockSelect).not.toHaveBeenCalled();
     expect(mockSpawn).toHaveBeenCalledWith(
-      "npx skills add haydenbleasel/ultracite",
-      [],
+      "npx",
+      ["skills", "add", "haydenbleasel/ultracite"],
       expect.objectContaining({
-        shell: true,
+        shell: false,
         stdio: "pipe",
       })
     );
diff --git a/packages/cli/src/integrations/husky.ts b/packages/cli/src/integrations/husky.ts
@@ -1,9 +1,9 @@
-import { execSync } from "node:child_process";
 import { mkdir, readFile, writeFile } from "node:fs/promises";
 
 import { addDevDependency, dlxCommand } from "nypm";
 import type { PackageManager, PackageManagerName } from "nypm";
 
+import { runCommandSync } from "../run-command";
 import { exists, isMonorepo, updatePackageJson } from "../utils";
 
 const createLintStagedHookScript = (lintStagedCommand: string) => `#!/bin/sh
@@ -68,13 +68,13 @@ export const husky = {
   exists: () => exists(path),
   init: (packageManager: PackageManagerName) => {
     // Initialize husky - this sets up git hooks infrastructure
-    const initCommand = dlxCommand(packageManager, "husky", {
+    const [command, ...args] = dlxCommand(packageManager, "husky", {
       args: ["init"],
-    });
+    }).split(" ");
+
+    const result = runCommandSync(command, args, { stdio: "pipe" });
 
-    try {
-      execSync(initCommand, { stdio: "pipe" });
-    } catch {
+    if (result.error || (result.status !== null && result.status !== 0)) {
       // If init fails, it might be because it's already initialized
       // Continue anyway as we'll create the hook file next
     }
diff --git a/packages/cli/src/run-command.ts b/packages/cli/src/run-command.ts
@@ -24,15 +24,6 @@ export const runCommandSync = (
     shell: false,
   });
 
-export const runCommandShellSync = (
-  command: string,
-  options: RunCommandOptions
-): RunCommandResult =>
-  crossSpawnSync(command, [], {
-    ...options,
-    shell: true,
-  });
-
 export const exitOnCommandFailure = (
   commandName: string,
   result: RunCommandResult
diff --git a/packages/cli/src/skill.ts b/packages/cli/src/skill.ts
@@ -2,7 +2,7 @@ import { isCancel, select, spinner } from "@clack/prompts";
 import { dlxCommand } from "nypm";
 import type { PackageManagerName } from "nypm";
 
-import { runCommandShellSync } from "./run-command";
+import { runCommandSync } from "./run-command";
 
 const ultraciteSkillRepo = "haydenbleasel/ultracite";
 
@@ -54,14 +54,15 @@ export const maybeInstallUltraciteSkill = async ({
     return false;
   }
 
-  const command = buildUltraciteSkillInstallCommand(packageManager);
+  const fullCommand = buildUltraciteSkillInstallCommand(packageManager);
+  const [command, ...args] = fullCommand.split(" ");
   const s = spinner();
 
   if (!quiet) {
     s.start("Installing the Ultracite skill...");
   }
 
-  const result = runCommandShellSync(command, {
+  const result = runCommandSync(command, args, {
     stdio: "pipe",
   });
   const didInstall = !result.error && result.status === 0;

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"ultracite": patch
 +---
++
 +Remove remaining execSync calls