Fix type-aware

haydenbleasel · haydenbleasel · commit f84edfffc2b6 · 2026-03-12T21:16:51.000-07:00
diff --git a/.changeset/all-coats-fold.md b/.changeset/all-coats-fold.md
@@ -0,0 +1,5 @@
+---
+"ultracite": patch
+---
+
+Fix --type-aware for Biome
diff --git a/apps/docs/setup.mdx b/apps/docs/setup.mdx
@@ -24,7 +24,7 @@ You can optionally pass the following flags to the `init` command:
 | `--agents`          | The AI agents to configure.                      | Space-separated: `claude`, `codex`, `jules`, `copilot`, `cline`, `amp`, `aider`, `firebase-studio`, `open-hands`, `gemini`, `junie`, `augmentcode`, `kilo-code`, `goose`, `roo-code`, `warp`, `droid`, `opencode`, `crush`, `qwen`, `amazon-q-cli`, `firebender`, `cursor-cli`, `mistral-vibe`, `vercel` |
 | `--hooks`           | The agent hooks to configure.                    | Space-separated: `cursor`, `windsurf`, `claude`                         |
 | `--integrations`    | Additional integrations to setup.                | Space-separated: `husky`, `lefthook`, `lint-staged`, `pre-commit`       |
-| `--type-aware`      | Enable type-aware linting (oxlint only).         | (no value needed)                                                       |
+| `--type-aware`      | Enable type-aware linting. Adds project/scanner rules for Biome, installs `oxlint-tsgolint` for Oxlint. | (no value needed)                                                       |
 | `--skip-install`    | Skip installing dependencies.                    | (no value needed)                                                       |
 | `--quiet`           | Suppress interactive prompts and visual output.  | (no value needed, automatically enabled in CI)                          |
 
diff --git a/apps/docs/usage.mdx b/apps/docs/usage.mdx
@@ -57,19 +57,23 @@ You can also apply unsafe fixes (fixes that may change code behavior):
 npx ultracite fix --unsafe
 ```
 
-### Type-Aware Linting (Oxlint)
+### Type-Aware Linting
 
-When using Oxlint, you can enable type-aware linting rules that leverage TypeScript's type system.
+Type-aware linting enables deeper analysis rules that leverage TypeScript's type system and project structure. The `--type-aware` flag is passed during `ultracite init` and configures your project accordingly.
 
-To set up type-aware linting during initialization:
+#### Biome
+
+For Biome, `--type-aware` adds the `ultracite/biome/type-aware` preset to your Biome config's `extends` array. This enables project/scanner rules like `noPrivateImports`, `noUndeclaredDependencies`, `noUnresolvedImports`, `noImportCycles`, and `noDeprecatedImports`.
 
 ```bash title="Terminal"
-npx ultracite init --linter oxlint --type-aware
+npx ultracite init --linter biome --type-aware
 ```
 
-This installs the required `oxlint-tsgolint` dependency automatically.
+Since the rules are baked into your Biome config, they work in both the CLI and your IDE automatically — no runtime flags needed.
+
+#### Oxlint
 
-Then use the flags when checking or fixing:
+For Oxlint, `--type-aware` installs the required `oxlint-tsgolint` dependency. You then pass the flag at runtime when checking or fixing:
 
 ```bash title="Terminal"
 npx ultracite check --type-aware
@@ -92,7 +96,7 @@ npx ultracite fix --type-aware --type-check
 ```
 
 <Callout>
-These flags only apply when using Oxlint. They have no effect with Biome or ESLint.
+The `--type-aware` and `--type-check` runtime flags only apply to Oxlint. For Biome, type-aware rules are configured at init time and require no runtime flags.
 </Callout>
 
 ### Validating Setup
diff --git a/packages/cli/__tests__/check.test.ts b/packages/cli/__tests__/check.test.ts
@@ -45,41 +45,6 @@ describe("check", () => {
     expect(callArgs[1]).toContain("src/test.ts");
   });
 
-  test("adds --skip=project to biome by default", async () => {
-    const mockSpawn = mock(() => ({ status: 0 }));
-    mock.module("node:child_process", () => ({
-      spawnSync: mockSpawn,
-    }));
-    mock.module("../src/utils", () => ({
-      detectLinter: mock(async () => "biome"),
-      parseFilePaths,
-    }));
-
-    await check();
-
-    expect(mockSpawn).toHaveBeenCalled();
-    const callArgs = mockSpawn.mock.calls[0];
-    expect(callArgs[1]).toContain("--skip=project");
-  });
-
-  test("does not add --skip=project when --type-aware is passed to biome", async () => {
-    const mockSpawn = mock(() => ({ status: 0 }));
-    mock.module("node:child_process", () => ({
-      spawnSync: mockSpawn,
-    }));
-    mock.module("../src/utils", () => ({
-      detectLinter: mock(async () => "biome"),
-      parseFilePaths,
-    }));
-
-    await check([], ["--type-aware"]);
-
-    expect(mockSpawn).toHaveBeenCalled();
-    const callArgs = mockSpawn.mock.calls[0];
-    expect(callArgs[1]).not.toContain("--skip=project");
-    expect(callArgs[1]).not.toContain("--type-aware");
-  });
-
   test("passes through unknown options to biome", async () => {
     const mockSpawn = mock(() => ({ status: 0 }));
     mock.module("node:child_process", () => ({
diff --git a/packages/cli/__tests__/fix.test.ts b/packages/cli/__tests__/fix.test.ts
@@ -46,41 +46,6 @@ describe("fix", () => {
     expect(callArgs[1]).toContain("src/test.ts");
   });
 
-  test("adds --skip=project to biome by default", async () => {
-    const mockSpawn = mock(() => ({ status: 0 }));
-    mock.module("node:child_process", () => ({
-      spawnSync: mockSpawn,
-    }));
-    mock.module("../src/utils", () => ({
-      detectLinter: mock(async () => "biome"),
-      parseFilePaths,
-    }));
-
-    await fix([]);
-
-    expect(mockSpawn).toHaveBeenCalled();
-    const callArgs = mockSpawn.mock.calls[0];
-    expect(callArgs[1]).toContain("--skip=project");
-  });
-
-  test("does not add --skip=project when --type-aware is passed to biome", async () => {
-    const mockSpawn = mock(() => ({ status: 0 }));
-    mock.module("node:child_process", () => ({
-      spawnSync: mockSpawn,
-    }));
-    mock.module("../src/utils", () => ({
-      detectLinter: mock(async () => "biome"),
-      parseFilePaths,
-    }));
-
-    await fix([], ["--type-aware"]);
-
-    expect(mockSpawn).toHaveBeenCalled();
-    const callArgs = mockSpawn.mock.calls[0];
-    expect(callArgs[1]).not.toContain("--skip=project");
-    expect(callArgs[1]).not.toContain("--type-aware");
-  });
-
   test("passes through --unsafe option to biome", async () => {
     const mockSpawn = mock(() => ({ status: 0 }));
     mock.module("node:child_process", () => ({
diff --git a/packages/cli/config/biome/core/biome.jsonc b/packages/cli/config/biome/core/biome.jsonc
@@ -226,12 +226,12 @@
         "noProcessGlobal": "off",
         "useUniqueElementIds": "off",
 
-        /** ------ Project/Scanner rules. Enabled in config but skipped by default at runtime for performance. Use --type-aware to enable. ------ **/
-        "noPrivateImports": "error",
-        "noUndeclaredDependencies": "error",
-        "noUnresolvedImports": "error",
-        "useImportExtensions": "error",
-        "useJsonImportAttributes": "error",
+        /** ------ Project/Scanner rules. Use ultracite/biome/type-aware to enable. ------ **/
+        "noPrivateImports": "off",
+        "noUndeclaredDependencies": "off",
+        "noUnresolvedImports": "off",
+        "useImportExtensions": "off",
+        "useJsonImportAttributes": "off",
 
         /** ------------------------ CSS Rules ------------------------ **/
         "noInvalidDirectionInLinearGradient": "error",
@@ -461,9 +461,9 @@
 
         "noConsole": "off",
 
-        /** ------ Project/Scanner rules. Enabled in config but skipped by default at runtime for performance. Use --type-aware to enable. ------ **/
-        "noDeprecatedImports": "error",
-        "noImportCycles": "error",
+        /** ------ Project/Scanner rules. Use ultracite/biome/type-aware to enable. ------ **/
+        "noDeprecatedImports": "off",
+        "noImportCycles": "off",
 
         /** ------------------------ CSS Rules ------------------------ **/
         "noDuplicateAtImportRules": "error",
diff --git a/packages/cli/config/biome/type-aware/biome.jsonc b/packages/cli/config/biome/type-aware/biome.jsonc
@@ -0,0 +1,19 @@
+{
+	"root": false,
+	"$schema": "../../../node_modules/@biomejs/biome/configuration_schema.json",
+	"linter": {
+		"rules": {
+			"correctness": {
+				"noPrivateImports": "error",
+				"noUndeclaredDependencies": "error",
+				"noUnresolvedImports": "error",
+				"useImportExtensions": "error",
+				"useJsonImportAttributes": "error"
+			},
+			"suspicious": {
+				"noDeprecatedImports": "error",
+				"noImportCycles": "error"
+			}
+		}
+	}
+}
diff --git a/packages/cli/src/commands/check.ts b/packages/cli/src/commands/check.ts
@@ -3,16 +3,7 @@ import process from "node:process";
 import { detectLinter, parseFilePaths, shellOption } from "../utils";
 
 const runBiomeCheck = (files: string[], passthrough: string[]): void => {
-  const hasTypeAware = passthrough.includes("--type-aware");
-  const filtered = passthrough.filter((arg) => arg !== "--type-aware");
-
-  const args = ["check", "--no-errors-on-unmatched"];
-
-  if (!hasTypeAware) {
-    args.push("--skip=project");
-  }
-
-  args.push(...filtered);
+  const args = ["check", "--no-errors-on-unmatched", ...passthrough];
 
   if (files.length > 0) {
     args.push(...parseFilePaths(files));
diff --git a/packages/cli/src/commands/fix.ts b/packages/cli/src/commands/fix.ts
@@ -3,16 +3,7 @@ import process from "node:process";
 import { detectLinter, parseFilePaths, shellOption } from "../utils";
 
 const runBiomeFix = (files: string[], passthrough: string[]): void => {
-  const hasTypeAware = passthrough.includes("--type-aware");
-  const filtered = passthrough.filter((arg) => arg !== "--type-aware");
-
-  const args = ["check", "--write", "--no-errors-on-unmatched"];
-
-  if (!hasTypeAware) {
-    args.push("--skip=project");
-  }
-
-  args.push(...filtered);
+  const args = ["check", "--write", "--no-errors-on-unmatched", ...passthrough];
 
   if (files.length > 0) {
     args.push(...parseFilePaths(files));
diff --git a/packages/cli/src/initialize.ts b/packages/cli/src/initialize.ts
@@ -186,11 +186,10 @@ export const installDependencies = async (
   }
 
   // Add ultracite scripts to package.json
-  const typeAwareFlag = typeAware ? " --type-aware" : "";
   await updatePackageJson({
     scripts: {
-      check: `ultracite check${typeAwareFlag}`,
-      fix: `ultracite fix${typeAwareFlag}`,
+      check: "ultracite check",
+      fix: "ultracite fix",
     },
   });
 
@@ -307,7 +306,8 @@ export const upsertEditorConfig = async (
 
 export const upsertBiomeConfig = async (
   frameworks?: (typeof options.frameworks)[number][],
-  quiet = false
+  quiet = false,
+  typeAware = false
 ) => {
   const s = spinner();
 
@@ -319,7 +319,7 @@ export const upsertBiomeConfig = async (
     if (!quiet) {
       s.message("Biome configuration found, updating...");
     }
-    await biome.update({ frameworks });
+    await biome.update({ frameworks, typeAware });
     if (!quiet) {
       s.stop("Biome configuration updated.");
     }
@@ -329,7 +329,7 @@ export const upsertBiomeConfig = async (
   if (!quiet) {
     s.message("Biome configuration not found, creating...");
   }
-  await biome.create({ frameworks });
+  await biome.create({ frameworks, typeAware });
   if (!quiet) {
     s.stop("Biome configuration created.");
   }
@@ -949,7 +949,7 @@ export const initialize = async (flags?: InitializeFlags) => {
 
     // Create config for selected linter
     if (linter === "biome") {
-      await upsertBiomeConfig(frameworks, quiet);
+      await upsertBiomeConfig(frameworks, quiet, opts["type-aware"]);
     }
     if (linter === "eslint") {
       await upsertEslintConfig(frameworks, quiet);
diff --git a/packages/cli/src/linters/biome.ts b/packages/cli/src/linters/biome.ts
@@ -19,6 +19,7 @@ const getBiomeConfigPath = async (): Promise<string> => {
 
 interface BiomeOptions {
   frameworks?: (typeof options.frameworks)[number][];
+  typeAware?: boolean;
 }
 
 export const biome = {
@@ -30,6 +31,11 @@ export const biome = {
     const path = await getBiomeConfigPath();
     const extendsList = ["ultracite/biome/core"];
 
+    // Add type-aware config for project/scanner rules
+    if (opts?.typeAware) {
+      extendsList.push("ultracite/biome/type-aware");
+    }
+
     // Add framework-specific configs
     if (opts?.frameworks && opts.frameworks.length > 0) {
       for (const framework of opts.frameworks) {
@@ -67,6 +73,11 @@ export const biome = {
       newExtends.push("ultracite/biome/core");
     }
 
+    // Add type-aware config for project/scanner rules
+    if (opts?.typeAware && !newExtends.includes("ultracite/biome/type-aware")) {
+      newExtends.push("ultracite/biome/type-aware");
+    }
+
     // Add framework-specific configs if provided
     if (opts?.frameworks && opts.frameworks.length > 0) {
       for (const framework of opts.frameworks) {

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"ultracite": patch
 +---
++
 +Fix --type-aware for Biome