Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: handle additionalProperties empty object as unknown instead of preserving an empty interface#1982

Merged
mrlubos merged 1 commit intomainfrom
fix/additional-properties-unknown-2
Apr 27, 2025
Merged

fix: handle additionalProperties empty object as unknown instead of preserving an empty interface#1982
mrlubos merged 1 commit intomainfrom
fix/additional-properties-unknown-2

Conversation

@mrlubos
Copy link
Member

@mrlubos mrlubos commented Apr 27, 2025

Closes #1815

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@mrlubos mrlubos marked this pull request as ready for review April 27, 2025 18:29
@vercel
Copy link

vercel bot commented Apr 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2025 6:30pm

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 27, 2025

Open in StackBlitz

@hey-api/client-axios

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-axios@1982

@hey-api/client-fetch

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-fetch@1982

@hey-api/client-next

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-next@1982

@hey-api/client-nuxt

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-nuxt@1982

@hey-api/nuxt

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@1982

@hey-api/openapi-ts

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@1982

@hey-api/vite-plugin

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@1982

commit: 1e6d74f

@codecov
Copy link

codecov bot commented Apr 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 22.26%. Comparing base (92f70c8) to head (1e6d74f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ages/openapi-ts/src/openApi/2.0.x/parser/schema.ts 0.00% 1 Missing ⚠️
...ages/openapi-ts/src/openApi/3.0.x/parser/schema.ts 0.00% 1 Missing ⚠️
...ages/openapi-ts/src/openApi/3.1.x/parser/schema.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1982      +/-   ##
==========================================
+ Coverage   22.24%   22.26%   +0.01%     
==========================================
  Files         251      251              
  Lines       21165    21150      -15     
  Branches      783      783              
==========================================
  Hits         4709     4709              
+ Misses      16450    16435      -15     
  Partials        6        6              
Flag Coverage Δ
unittests 22.26% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrlubos mrlubos merged commit 149210e into main Apr 27, 2025
16 of 17 checks passed
@mrlubos mrlubos deleted the fix/additional-properties-unknown-2 branch April 27, 2025 18:35
@github-actions github-actions bot mentioned this pull request Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Record types being generated differently

1 participant