fix(bun): improve musl detection logic using runtime detection#10195
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Bun plugin imports runtime libc detection ( ChangesBun musl detection enhancement
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates Bun platform detection to better identify musl systems at runtime, improving release artifact selection.
Changes:
- Switches
is_musl()from compile-time target checks to runtime libc detection viadetect_libc. - Consolidates imports to include
detect_libcalongside existing checksum helper.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Greptile SummaryThis PR fixes musl detection for the Bun plugin on Linux. Previously, the fallback path in
Confidence Score: 5/5Safe to merge — a one-line logic change backed by an existing runtime detection function that already handles known edge cases. The change swaps a baked-in compile-time assumption for the existing detect_libc() runtime check, which handles the Alpine + gcompat case, linker file inspection, and a compile-time fallback internally. Non-Linux behaviour is unchanged since detect_libc() returns None there. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "fix(bun): improve musl detection logic u..." | Re-trigger Greptile |
Fixes an issue with
glibcfallback for bun as mentioned in #10185Summary by CodeRabbit