Fix test_authorizer having a spurious comma in params#1664
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a test parametrization typo in test_authorizer that can cause CI failures by giving pytest.mark.parametrize an invalid parameter name (a trailing comma in the parameter string).
Changes:
- Remove the trailing comma from the
pytest.mark.parametrizeparameter name ("jp_server_config,"→"jp_server_config"), ensuring pytest can correctly bind the fixture/config argument.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
Self-merging per previous discussion (#jupyter-server > general chat @ 💬) since this just a single character change. |
sfc-gh-sbirmiwal
pushed a commit
to sfc-gh-sbirmiwal/jupyter_server
that referenced
this pull request
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CI failure seen on
mainand in PRs (#1662 and #1656)