Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jhdm
Copy link
Contributor

@jhdm jhdm commented Aug 28, 2024

Fixing warning "Property extends is not allowed" on "extends" property in user's lerna.json.

Description

When user has "extends" property in user's lerna.json, for example,

"extends": "my-base-config"

VS Code shows "squiggly" warning "Property extends is not allowed" on the extends property:

image

Motivation and Context

Fix the VS Code warning on the extends property.

This is follow-up on the "extends" feature implemented the commit, which was for Issue #1281.

How Has This Been Tested?

Use the updated lerna-schema.json file in the lerna package installation. After the fix, VS Code no longer shows that warning:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Fixing issue that VS Code shows "squiggly" underline warning on "extends"
property in user's lerna.json:

"extends": "my-base-config"

This adds schema update for the "extends" feature implemented in,
lerna@0b28ef5
which was for issue,
lerna#1281

After the fix, VS Code no longer shows that warning.
@nx-cloud
Copy link

nx-cloud bot commented Aug 29, 2024

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jhdm!

@JamesHenry JamesHenry changed the title fix(schema): add extends property in schema fix: add extends property in schema Aug 29, 2024
@JamesHenry JamesHenry enabled auto-merge (squash) August 29, 2024 09:20
@JamesHenry JamesHenry merged commit 28c8ef2 into lerna:main Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants