Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix typo: type annotions -> type annotations in PEP 560 comments#504

Merged
scoder merged 1 commit into
lxml:masterfrom
mokashang:fix/type-annotations-typo
May 17, 2026
Merged

Fix typo: type annotions -> type annotations in PEP 560 comments#504
scoder merged 1 commit into
lxml:masterfrom
mokashang:fix/type-annotations-typo

Conversation

@mokashang
Copy link
Copy Markdown
Contributor

The comment # Allow subscripting <Class> in type annotions (PEP 560) was copy-pasted to four locations with the same typo (annotions instead of annotations). Fixed in builder.py, parser.pxi (twice) and sax.py.

Comment-only change, no behavioural impact.

@scoder scoder merged commit 3bd86c0 into lxml:master May 17, 2026
@scoder
Copy link
Copy Markdown
Member

scoder commented May 17, 2026

Thanks

@cclauss
Copy link
Copy Markdown
Contributor

cclauss commented May 30, 2026

I would avoid putting the misspelling in the commit title because many repos publish changelogs with the title of landed pull requests, which perpetuates the misspelling in the docs. This means that typo discovery tools such as codespell will need to have that typo added to their --ignore-words-list which blinds those tools to future regressions.

@scoder
Copy link
Copy Markdown
Member

scoder commented May 30, 2026

Oh well… thanks for noting this. :-/
OTOH, commit logs are usually generated and shouldn't be part of spell checks. Might not be easy to exclude in some cases, but I don't see value in including them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants