Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Ignore Azure.Cosmos.Requests source#2789

Merged
TimothyMothra merged 4 commits into
microsoft:mainfrom
lmolkova:cosmos-ignore-requests
Aug 7, 2023
Merged

Ignore Azure.Cosmos.Requests source#2789
TimothyMothra merged 4 commits into
microsoft:mainfrom
lmolkova:cosmos-ignore-requests

Conversation

@lmolkova

@lmolkova lmolkova commented Jun 16, 2023

Copy link
Copy Markdown

Changes

Cosmos DB team does not want to report transport calls via Application Insights. This PR ignores corresponding source and only listens to Azure.Cosmos.Operation

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

@lmolkova lmolkova force-pushed the cosmos-ignore-requests branch from 0790d18 to 1a75cc3 Compare June 16, 2023 19:36
@TimothyMothra

Copy link
Copy Markdown

@lmolkova is this ready for review? The PR is still a Draft.

@TimothyMothra

Copy link
Copy Markdown

Please update the changelog.

@lmolkova lmolkova marked this pull request as ready for review July 18, 2023 22:08
@lmolkova

Copy link
Copy Markdown
Author

thank you @TimothyMothra, I updated the changelog!
It is ready for review.

@sourabh1007 please approve if you're fine with the changes.

@TimothyMothra TimothyMothra left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmolkova

lmolkova commented Aug 4, 2023

Copy link
Copy Markdown
Author

Thanks @sourabh1007 for the review!

@TimothyMothra I belive it's ready to be merged if you're still fine with it. Thank you!

@lmolkova lmolkova force-pushed the cosmos-ignore-requests branch from e6466da to 05219af Compare August 5, 2023 01:08
@TimothyMothra TimothyMothra merged commit 1769773 into microsoft:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants