Fixed issue not checking for DONE token errors properly so exceptions are ignored (backport of 1857, 1943, 1989 to 10.2.2) #1990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Just double checking, the descriptions says "backporting #1989", that's a typo right? I don't think we need to backport 1989 since the ICR issue it fixes isn't in 10.2.1 (plus I didn't notice any code changes in this PR from 1989). |
tkyc
reviewed
Dec 6, 2022
| {"R_crCommandCannotTimeOut", "Request failed to time out and SQLServerConnection does not exist"}, | ||
| {"R_UnableLoadAuthDll", "Unable to load authentication DLL {0}"}, | ||
| }; | ||
| {"R_serverError", "An error occurred during the current command (Done status {0}). {1}"}, |
Contributor
There was a problem hiding this comment.
Reminder to copy over localizations from main to the servicing branch in the VSO repo.
tkyc
approved these changes
Dec 6, 2022
Jeffery-Wasty
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #1857 #1943 and #1989