Handle DBus UnknownObject error when no collection is found#43
Merged
Conversation
On Kubuntu 23.04, when trying to access a collection that doesn't exist, it returns a UknownObject error instead of NoSuchObject. Which makes me unable of installing the package on the system. Handling this case, makes the KWallet dialog for creating the wallet appear and the rest of workflow works as expected.
mitya57
reviewed
Aug 30, 2023
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
+ Coverage 93.54% 93.55% +0.01%
==========================================
Files 14 14
Lines 558 559 +1
==========================================
+ Hits 522 523 +1
Misses 36 36
|
Owner
|
Thank you! |
Contributor
Author
|
Just leaving a better report on the actual error, I couldn't investigate further into the reasons that happens tho. |
Owner
|
So just the tests fail, but the library itself works fine? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Kubuntu 23.04, when trying to access a collection that doesn't exist, it returns a UnknownObject error instead of NoSuchObject. Which makes me unable of installing the package on the system.
Handling this case, makes the KWallet dialog for creating the wallet appears and the rest of workflow works as expected.