Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: use original require() error for TS files if ERR_UNKNOWN_FILE_EXTENSION #5408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 30, 2025
Merged

fix: use original require() error for TS files if ERR_UNKNOWN_FILE_EXTENSION #5408

merged 9 commits into from
Sep 30, 2025

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jul 29, 2025 •
edited by mark-wiemer
Loading

PR Checklist

Overview

Adds in a special-case try/catch -> throw. If the file being imported is a .cts, .mts, or .ts and the caught error from import() is for an unknown file extension, we know it's from a Node.js version that doesn't support those file extensions. In that case we'll want to throw the original informative require() error per #5393.

💖

@JoshuaKGoldberg JoshuaKGoldberg changed the title fix: use original require() error if ERR_UNKNOWN_FILE_EXTENSION fix: use original require() error for TS files if ERR_UNKNOWN_FILE_EXTENSION Jul 29, 2025
mark-wiemer
mark-wiemer requested changes Jul 29, 2025
View reviewed changes
mark-wiemer
mark-wiemer reviewed Jul 29, 2025
View reviewed changes
@JoshuaKGoldberg JoshuaKGoldberg added the status: blocked Waiting for something else to be resolved label Aug 5, 2025
@JoshuaKGoldberg JoshuaKGoldberg removed the status: blocked Waiting for something else to be resolved label Sep 1, 2025
JoshuaKGoldberg
JoshuaKGoldberg commented Sep 1, 2025
View reviewed changes
JoshuaKGoldberg
JoshuaKGoldberg commented Sep 25, 2025
View reviewed changes
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Sep 25, 2025
Closed
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Sep 25, 2025
Closed
5 tasks
@JoshuaKGoldberg
Copy link
Member Author

cc @mark-wiemer - none of the test failures are unique to this PR. I filed #5467.

@JoshuaKGoldberg JoshuaKGoldberg merged commit ebdbc48 into mochajs:main Sep 30, 2025
89 of 93 checks passed
@github-actions github-actions bot mentioned this pull request Sep 30, 2025
Merged
@JoshuaKGoldberg JoshuaKGoldberg deleted the require-module-syntax-throw branch September 30, 2025 13:58
@mark-wiemer mark-wiemer mentioned this pull request Oct 4, 2025
Open
5 tasks
@Geam Geam mentioned this pull request Oct 7, 2025
Open
4 tasks
@mark-wiemer mark-wiemer mentioned this pull request Oct 10, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mark-wiemer mark-wiemer mark-wiemer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 Bug: original require() errors are masked with an unrelated ERR_UNKNOWN_FILE_EXTENSION

2 participants

@JoshuaKGoldberg @mark-wiemer